-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter allowed encoding to error descriptions #2691
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
Apr 23, 2024
jaceklyp
removed
the
bot: not in app board
Added by automation for pull requests with tasks not added to macOS App Board Asana project
label
Apr 23, 2024
SlayterDev
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaceklyp this looks good but I think you had a couple inadvertent changes in this PR. Just double check the diff before merging.
jaceklyp
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Apr 24, 2024
Task/Issue URL: https://app.asana.com/0/1203790657351911/1207097497487052/f iOS PR: duckduckgo/iOS#2781 macOS PR: duckduckgo/macos-browser#2691 What kind of version bump will this require?: Patch
samsymons
added a commit
that referenced
this pull request
Apr 24, 2024
* main: (22 commits) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags Bump version to 1.85.0 (174) Revert interrupt logic (#2699) Fix downloads not appearing (#2693) Bump version to 1.85.0 (173) DBP interrupt fixes for release (#2696) Bookmark All Tabs (#2683) Fix DBP interrupt function not being cleared on succesful completion (#2690) Bump version to 1.85.0 (172) Validate DBP permissions (#2673) Bump BSK (#2688) Add Untitled tab title (#2650) Stop first scan completed notification being sent if there's an error (#2685) DBP: Rename scanAllBrokers to startManualScan (#2679) macOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2652) Bump version to 1.85.0 (171) [Release PR] Link Lottie with the NetworkProtectionUI library (#2676) ...
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Dax the Duck (9) and others # Via GitHub (6) and others * main: (47 commits) Update BSK to 141.1.1 (#2713) macOS: VPN Metadata Improvements (#2704) duck page suggestions (#2666) macOS: Add pixels to track VPN wake and stop attempts (#2694) Trusted url indicator (#2665) remove Tab.TabContent.url (#2647) Bump version to 1.85.0 (176) Update release automation to support Privacy Pro section in release notes (#2710) Fix for VPN stop issues. (#2689) Hard-codes the VPN waitlist flags to ON (#2709) Add subscription status to the macOS metadata (#2680) Bump version to 1.85.0 (175) Call finish in the correct place (#2702) Fix layout issue on DBP (#2700) Update autoconsent to v10.6.1 (#2618) Make Clear All History shortcut available without entering Main Menu (#2682) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203790657351911/1207097497487052/f
Steps to test this PR:
See: duckduckgo/BrowserServicesKit#795
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation